Skip to content

oci: Revamp cfsctl oci #232

Open
cgwalters wants to merge 3 commits intocomposefs:mainfrom
cgwalters:cli-improvements
Open

oci: Revamp cfsctl oci #232
cgwalters wants to merge 3 commits intocomposefs:mainfrom
cgwalters:cli-improvements

Conversation

@cgwalters
Copy link
Collaborator

  • cfsctl oci inspect now outputs JSON with full metadata, and supports
    --manifest/--config.
  • cfsctl oci images now includes referrer count and also supports --json
  • cfsctl oci layer is new and can output tar or dumpfile or json metadata

Assisted-by: OpenCode (Claude claude-opus-4-5-20250514)

@Johan-Liebert1
Copy link
Collaborator

DCO seems to be having issues

@cgwalters
Copy link
Collaborator Author

Feel free to force push any updates to this one for example

- `cfsctl oci inspect` now outputs JSON with full metadata, and supports
  `--manifest/--config`.
- `cfsctl oci images` now includes referrer count and also supports `--json`
- `cfsctl oci layer` is new and can output tar or dumpfile or json metadata

Assisted-by: OpenCode (Claude claude-opus-4-5-20250514)
Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
So we get correct line wrapping.

Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Fixes the package check.

Signed-off-by: Colin Walters <walters@verbum.org>
Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
@Johan-Liebert1
Copy link
Collaborator

I don't have permissions to do this, @allisonkarlitskaya could you look into the DCO issue?

Comment on lines +508 to +512
} else if dumpfile {
composefs_oci::layer_dumpfile(&repo, layer, &mut std::io::stdout())?;
} else {
// Default: output raw tar
composefs_oci::layer_tar(&repo, layer, &mut std::io::stdout())?;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we care whether the output is a tty?

Copy link
Contributor

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question, otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants